Added helloWorld TypeScript test PDP

[tjcouch-sil]

• Hello World TypeScript test PDP - doesn't persist data because PSIE is unimplemented
• Added projectType filters to project dialogs
• Handful of bug fixes on PDP apis
• Fixed command-line arguments bug
• Updated from templates to fix swc bug
• Moved mutex map to util library
• Auto-pull dependencies for externals in vite projects

Resolves #509

---

This change is 

[lyonsil]

Reviewed 55 of 55 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @tjcouch-sil)

---

extensions/src/hello-world/src/models/hello-world-project-data-provider-engine.model.ts line 26 at r1 (raw file):

  async setRandomNumber(max: number, newNum: number) {
    if (newNum === this.numbers[max]) return false;

I don't understand max here, but it's just a test so it doesn't really matter. I think max is really just meant to be any index, but then I don't know why it's called max in so many places.

---

src/shared/services/project-lookup.service.test.ts line 7 at r1 (raw file):

describe('filterProjectsMetadata', () => {
  test('should return a shallow clone if there are no filters', () => {
    const projectsMetadata: ProjectMetadata[] = [

It looks like you use the same ProjectMetadata[] repeatedly in each test. You could just declare it above the tests and save space/reading, but not a big deal.

---

src/shared/services/project-lookup.service.test.ts line 48 at r1 (raw file):

    expect(filteredMetadata.length).toEqual(1);

    // Precedence over includeProjectTypes

I wouldn't technically call this precedence in that one filter option isn't really being favored over another. Instead it's the case that all filter options have to be met for each item returned.

[tjcouch-sil]

Reviewable status: 51 of 55 files reviewed, 3 unresolved discussions (waiting on @lyonsil)

---

extensions/src/hello-world/src/models/hello-world-project-data-provider-engine.model.ts line 26 at r1 (raw file):

Previously, lyonsil (Matt Lyons) wrote…

I don't understand max here, but it's just a test so it doesn't really matter. I think max is really just meant to be any index, but then I don't know why it's called max in so many places.

max is the max number the random number can be. It's very weird and not immensely sensible indeed. I was struggling to think of anything 😂 I adjusted to make it work more precisely as a max value and added some comments to the .d.ts that will hopefully make it a bit more understandable

---

src/shared/services/project-lookup.service.test.ts line 7 at r1 (raw file):

Previously, lyonsil (Matt Lyons) wrote…

It looks like you use the same ProjectMetadata[] repeatedly in each test. You could just declare it above the tests and save space/reading, but not a big deal.

Oh yeah, I think I just assumed I would change some things as I wrote them, so I put it in each one. But now they're all done, and they're all the same. Changed :)

---

src/shared/services/project-lookup.service.test.ts line 48 at r1 (raw file):

Previously, lyonsil (Matt Lyons) wrote…

I wouldn't technically call this precedence in that one filter option isn't really being favored over another. Instead it's the case that all filter options have to be met for each item returned.

Gotcha. Adjusted wording!

[lyonsil]

Reviewed 3 of 4 files at r2, all commit messages.
Reviewable status: 54 of 55 files reviewed, 1 unresolved discussion (waiting on @tjcouch-sil)

---

extensions/src/hello-world/src/models/hello-world-project-data-provider-engine.model.ts line 26 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

max is the max number the random number can be. It's very weird and not immensely sensible indeed. I was struggling to think of anything 😂 I adjusted to make it work more precisely as a max value and added some comments to the .d.ts that will hopefully make it a bit more understandable

Honestly this still is kind of confusing since it's being used both as an index and a maximum value for the data, but it's just code to include as a test temporarily, so it doesn't matter that much.

[tjcouch-sil]

Reviewable status: 54 of 55 files reviewed, all discussions resolved (waiting on @lyonsil)

---

extensions/src/hello-world/src/models/hello-world-project-data-provider-engine.model.ts line 26 at r1 (raw file):

Previously, lyonsil (Matt Lyons) wrote…

Honestly this still is kind of confusing since it's being used both as an index and a maximum value for the data, but it's just code to include as a test temporarily, so it doesn't matter that much.

I'm just going to leave it for now. Agreed that it's not great. Maybe we can change it some day - maybe when we implement the PSI.

[lyonsil]

Reviewed 1 of 4 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved