Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux release #10

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Fix Linux release #10

merged 3 commits into from
Feb 1, 2023

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Jan 30, 2023

  • add missing packages for Linux, 64 found so far
  • similar to sudo apt install libnss3 libasound2 libgbm1 libgl1 libgtk-3-0
  • this takes the .AppImage file from 87 MB to 98 MB

Fix GHA build

  • on Linux, use no hardlinks so source dependency *.so files are copied to the build (rather than linked)

Separate Linux release

  • since it needs .so files (not available on MacOS)

- add missing packages for Linux, 64 found so far
- similar to `sudo apt install libnss3 libasound2 libgbm1 libgl1 libgtk-3-0`
- this takes the `.AppImage` file from 87 MB to 98 MB
@irahopkinson irahopkinson force-pushed the fix/linuxRelease branch 18 times, most recently from b90f832 to e86d74f Compare February 1, 2023 01:24
@irahopkinson irahopkinson marked this pull request as ready for review February 1, 2023 01:33
@irahopkinson irahopkinson marked this pull request as draft February 1, 2023 03:17
- on Linux, use no hardlinks so source dependency *.so files are copied to the build (rather than linked)
- since it needs .so files (not available on MacOS)
@irahopkinson irahopkinson marked this pull request as ready for review February 1, 2023 03:58
@irahopkinson irahopkinson merged commit 7007816 into main Feb 1, 2023
@irahopkinson irahopkinson deleted the fix/linuxRelease branch February 1, 2023 18:54
@irahopkinson irahopkinson linked an issue Feb 2, 2023 that may be closed by this pull request
4 tasks
tjcouch-sil added a commit that referenced this pull request Feb 16, 2024
514575f38 Fixed swc bindings not found error (#10)
186b4c7d2 Fixed swc bindings not found error

git-subtree-dir: extensions
git-subtree-split: 514575f383e952576efc5b79f61d2b699970bd3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello World for Electron
2 participants