Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of context menus (#707) and making grid menu use composed JSON menus (#424) #746

Merged
merged 29 commits into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
74b8670
#707 [WIP]: Refactored the GridMenu component to create a SimpleMenu …
tombogle Jan 26, 2024
5431012
Merge remote-tracking branch 'origin/main' into 707-context-menus
tombogle Jan 26, 2024
b125046
#707 [WIP]: Got simple (context) menu to work in Storybook
tombogle Jan 29, 2024
272f2b1
#707 [WIP]: Renamed sim simple-menu to menu-item-list and added conte…
tombogle Jan 30, 2024
f438406
#707 [WIP]: Got context menu target content to lay out correctly (lin…
tombogle Feb 2, 2024
cb786ad
Merge remote-tracking branch 'origin/main' into 707-context-menus
tombogle Feb 2, 2024
3a9e6c2
Merge remote-tracking branch 'origin/main' into 707-context-menus
tombogle Feb 5, 2024
be5e7f6
707: Got menus working in platform.bible. [WIP] Some unit tests still…
tombogle Feb 20, 2024
4640cc1
Merge remote-tracking branch 'origin/main' into 707-context-menus
tombogle Feb 22, 2024
75bfb95
707: Fixed some failing unit tests. [WIP] One more failing unit test …
tombogle Feb 22, 2024
b5c3580
707: Broke unit tests into two files. All tests pass now.
tombogle Feb 22, 2024
9ea642a
707: Improved unit tests (and accessibility for the components themse…
tombogle Feb 23, 2024
ee75b96
Merge branch 'main' into 707-context-menus
tombogle Feb 26, 2024
7b6d988
707: Minor improvements in response to code review
tombogle Feb 26, 2024
dd7b4dd
707: Updated dist files after build
tombogle Feb 26, 2024
5ec68c6
707: Added unit tests for ContextMenu Component and fixed code to get…
tombogle Feb 27, 2024
a5c6983
707: Fixed some lint issues
tombogle Feb 27, 2024
302477e
707: Added contextMenu.component.onClick.test
tombogle Feb 27, 2024
ab13997
707: Got storybook working for menu stuff
tombogle Feb 27, 2024
d0103c0
707: Removed ability to launch debugger for current Jest test file si…
tombogle Feb 28, 2024
a8a739a
Merge branch 'main' into 707-context-menus
tombogle Feb 28, 2024
2410ec8
707: Improvements based on code review
tombogle Feb 28, 2024
233af67
707: More improvements based on code review
tombogle Feb 28, 2024
c802ebb
707: Got submenus and tooltips to work correctly
tombogle Feb 28, 2024
24365a2
707: Changed GroupedMenuItemList to take a single props parameter tha…
tombogle Feb 29, 2024
4ec4c99
707: In grouped-menu-item-list.component, wrapped calculation of item…
tombogle Feb 29, 2024
f2d5d83
Merge branch 'main' into 707-context-menus
tombogle Feb 29, 2024
43e6b98
707: Got arrow to appear on parent menu that displays a submenu.
tombogle Feb 29, 2024
3e1c307
424: Put convoluted foreach back to items.map (and now the linter is …
tombogle Feb 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { RuleSetRule } from 'webpack';

const config: StorybookConfig = {
stories: ['../src/**/*.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'],
staticDirs: ['../src/stories/assets'], // static asset folder
addons: [
'@storybook/addon-links',
'@storybook/addon-essentials',
Expand Down
1 change: 1 addition & 0 deletions cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"stylelint",
"Stylesheet",
"typedefs",
"unlocalized",
"unregistering",
"unregisters",
"unsub",
Expand Down
Loading
Loading