Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of context menus (#707) and making grid menu use composed JSON menus (#424) #746

Merged
merged 29 commits into from
Mar 1, 2024
Merged

Implementation of context menus (#707) and making grid menu use composed JSON menus (#424) #746

merged 29 commits into from
Mar 1, 2024

Commits on Jan 26, 2024

  1. #707 [WIP]: Refactored the GridMenu component to create a SimpleMenu … 

    …with no column header. Began hooking up in Storybook, but not working correctly yet.
    @tombogle
    tombogle committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    74b8670 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into 707-context-menus

    @tombogle
    tombogle committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    5431012 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. #707 [WIP]: Got simple (context) menu to work in Storybook

    @tombogle
    tombogle committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    b125046 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. #707 [WIP]: Renamed sim simple-menu to menu-item-list and added conte… 

    …xt-menu

Fixed up CSS to get Paratext/bright to work as expected
Added a sample icon file to use in Storybook
    @tombogle
    tombogle committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    272f2b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. #707 [WIP]: Got context menu target content to lay out correctly (lin… 

    …e wrapping)

Figured out styles so that color schemes apply to the correct elements. (This also fixes some things in the multi-column grid menu.
    @tombogle
    tombogle committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f438406 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into 707-context-menus

    @tombogle
    tombogle committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    cb786ad View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Merge remote-tracking branch 'origin/main' into 707-context-menus

    @tombogle
    tombogle committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    3a9e6c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. 707: Got menus working in platform.bible. [WIP] Some unit tests still… 

    … fail
    @tombogle
    tombogle committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    be5e7f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Merge remote-tracking branch 'origin/main' into 707-context-menus 

    # Conflicts:
#	src/renderer/components/platform-bible-menu.data.ts
    @tombogle
    tombogle committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4640cc1 View commit details
    Browse the repository at this point in the history

  2. 707: Fixed some failing unit tests. [WIP] One more failing unit test … 

    …remains.
    @tombogle
    tombogle committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    75bfb95 View commit details
    Browse the repository at this point in the history

  3. 707: Broke unit tests into two files. All tests pass now.

    @tombogle
    tombogle committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b5c3580 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. 707: Improved unit tests (and accessibility for the components themse… 

    …lves) by making use of accessible roles and labels
    @tombogle
    tombogle committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9ea642a View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'main' into 707-context-menus 

    # Conflicts:
#	extensions/package-lock.json
#	lib/platform-bible-react/dist/index.cjs
#	lib/platform-bible-react/dist/index.cjs.map
#	lib/platform-bible-react/dist/index.d.ts
#	lib/platform-bible-react/dist/index.js
#	lib/platform-bible-react/dist/index.js.map
#	lib/platform-bible-react/package-lock.json
    @tombogle
    tombogle committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    ee75b96 View commit details
    Browse the repository at this point in the history

  2. 707: Minor improvements in response to code review

    @tombogle
    tombogle committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    7b6d988 View commit details
    Browse the repository at this point in the history

  3. 707: Updated dist files after build

    @tombogle
    tombogle committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    dd7b4dd View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. 707: Added unit tests for ContextMenu Component and fixed code to get… 

    … them to pass
    @tombogle
    tombogle committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    5ec68c6 View commit details
    Browse the repository at this point in the history

  2. 707: Fixed some lint issues

    @tombogle
    tombogle committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a5c6983 View commit details
    Browse the repository at this point in the history

  3. 707: Added contextMenu.component.onClick.test

    @tombogle
    tombogle committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    302477e View commit details
    Browse the repository at this point in the history

  4. 707: Got storybook working for menu stuff

    @tombogle
    tombogle committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ab13997 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. 707: Removed ability to launch debugger for current Jest test file si… 

    …nce we now use Jest Runner to do that
    @tombogle
    tombogle committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    d0103c0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 707-context-menus 

    # Conflicts:
#	package-lock.json
    @tombogle
    tombogle committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a8a739a View commit details
    Browse the repository at this point in the history

  3. 707: Improvements based on code review

    @tombogle
    tombogle committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2410ec8 View commit details
    Browse the repository at this point in the history

  4. 707: More improvements based on code review

    @tombogle
    tombogle committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    233af67 View commit details
    Browse the repository at this point in the history

  5. 707: Got submenus and tooltips to work correctly

    @tombogle
    tombogle committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c802ebb View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. 707: Changed GroupedMenuItemList to take a single props parameter tha… 

    …t has includedGroups. Renamed and moved a few types around. Improved/added some comments.
    @tombogle
    tombogle committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    24365a2 View commit details
    Browse the repository at this point in the history

  2. 707: In grouped-menu-item-list.component, wrapped calculation of item… 

    …s and allowForLeadingIcons in useMemo
    @tombogle
    tombogle committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    4ec4c99 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 707-context-menus

    @tombogle
    tombogle committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f2d5d83 View commit details
    Browse the repository at this point in the history

  4. 707: Got arrow to appear on parent menu that displays a submenu.

    @tombogle
    tombogle committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    43e6b98 View commit details
    Browse the repository at this point in the history

  5. 424: Put convoluted foreach back to items.map (and now the linter is … 

    …okay with it)

Added warning when unexpected property on columns is not a valid column
    @tombogle
    tombogle committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3e1c307 View commit details
    Browse the repository at this point in the history