Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Comboboxes to Selects in example setting components #629

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

jolierabideau
Copy link
Contributor

@jolierabideau jolierabideau commented Nov 7, 2023

The PAPI ComboBox is based on MUI Autocomplete. While you can disableClearable, you cannot disable typing into the dropdown- which is desired for settings. This fix changes the ComboBoxes into Selects, which also gets rid of the exceptions for type assertion. In the "blanket" setting component, the only option that shows up is the default setting because it is stubbed and there aren't options for each. The selected option will also not show up in the value field because setSetting is also stubbed.

Screenshot 2023-11-07 at 5 40 13 PM

This change is Reviewable

@jolierabideau jolierabideau linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks! FYI I think long-term, we should probably make a boolean on the Combobox to determine whether you can type your own string in, but this is great for now.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@jolierabideau jolierabideau merged commit 07a9bf1 into main Nov 8, 2023
7 checks passed
@jolierabideau jolierabideau deleted the 618-improve-setting-selection branch November 8, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve setting selection
2 participants