Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setting selection #618

Closed
Sebastian-ubs opened this issue Nov 2, 2023 · 1 comment · Fixed by #629
Closed

Improve setting selection #618

Sebastian-ubs opened this issue Nov 2, 2023 · 1 comment · Fixed by #629
Assignees
Labels
bug Something isn't working

Comments

@Sebastian-ubs
Copy link
Contributor

Sebastian-ubs commented Nov 2, 2023

Describe the bug
After selecting an option, the dropdown only contains the selected option

(Storage functionality will only be implemented with #503, I assume that therefore on focus leave the value is reset to initial value)

To Reproduce
Steps to reproduce the behavior:

Action Result Screenshot
1. Open "Interface Language" dropdown All available grafik
2. Select "Spanish" Only selected option available grafik
3. Mark all. Type "en" Only matching options are available grafik

So the narrowing down of the drop down is probably to enable searching, but we don't need this, as jumping to entries also works without the typed characters appearing and filtering the list (see https://mui.com/material-ui/react-select/)

Expected behavior
Don't enable typing into the dropdowns, instead always show all selected options
Also the ability to clear text should not be available here

@Sebastian-ubs Sebastian-ubs added the bug Something isn't working label Nov 2, 2023
@Sebastian-ubs
Copy link
Contributor Author

This should later be part of the settings list in the shared settings component

@jolierabideau jolierabideau self-assigned this Nov 7, 2023
@jolierabideau jolierabideau moved this to 🏗 In progress in Paranext Nov 7, 2023
@jolierabideau jolierabideau moved this from 🏗 In progress to 👀 In review in Paranext Nov 7, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Paranext Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants