Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Settings: Rework Settings Dialog with extensible components #503

Open
tjcouch-sil opened this issue Sep 29, 2023 · 4 comments
Open

Comments

@tjcouch-sil
Copy link
Member

tjcouch-sil commented Sep 29, 2023

As a user, I want to be able to adjust settings that affect how I use Platform.Bible so I can configure it how I like to use it.

As an extension developer, I want to be able to provide settings that the user can edit in a central dialog so they can configure Platform.Bible how they want, and my extension will adjust accordingly.


Tightly coupled with #712. See #510 which is very similar

Settings & State Design Doc

@tjcouch-sil tjcouch-sil converted this from a draft issue Sep 29, 2023
@tjcouch-sil tjcouch-sil changed the title Global Settings: Create Settings Dialog Global Settings: Hook up Settings Dialog Oct 3, 2023
@tjcouch-sil tjcouch-sil moved this to Open in Paranext Oct 3, 2023
@tjcouch-sil tjcouch-sil changed the title Global Settings: Hook up Settings Dialog User Settings: Hook up Settings Dialog Oct 4, 2023
@Sebastian-ubs
Copy link
Contributor

For reimplementation use #621

@tjcouch-sil
Copy link
Member Author

How does https://github.com/sillsdev/config-r fit in?

@Sebastian-ubs
Copy link
Contributor

How does https://github.com/sillsdev/config-r fit in?

We have had a quick look and were not sure about the benefits if we want

  • to use a different ui library
  • a different style

Are there technical /functional benefits of reusing this?

@tjcouch-sil
Copy link
Member Author

I don't know but I imagine the UI and the functionality are separated in config-r. John Hatton told me something along the lines of that config-r might be useful in validating settings values based on a configuration input instead of having to build out a bunch of custom validation checking for it ourselves.

@katherinejensen00 katherinejensen00 moved this from 📥 For Consideration to 🎬 Product Backlog in Paranext Oct 16, 2024
@katherinejensen00 katherinejensen00 removed the status in Paranext Oct 16, 2024
@tjcouch-sil tjcouch-sil changed the title User Settings: Hook up Settings Dialog User Settings: Rework Settings Dialog with extensible components Oct 16, 2024
@tjcouch-sil tjcouch-sil moved this to 📥 For Consideration in Paranext Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📥 For Consideration
Development

No branches or pull requests

2 participants