Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more modules to be shared at load time with extensions #588

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

lyonsil
Copy link
Member

@lyonsil lyonsil commented Oct 23, 2023

This change is Reviewable

@lyonsil lyonsil linked an issue Oct 23, 2023 that may be closed by this pull request
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Would you mind also marking these as external in the bundled extensions?
paranext-core/extensions/webpack/webpack.config.base.ts at main · paranext/paranext-core
paranext-core/extensions/package.json at main · paranext/paranext-core

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually probably just in the webpack config external for now - we don't want to declare dependencies that aren't actually being used :) thanks!

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks for this!

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lyonsil lyonsil enabled auto-merge (squash) October 23, 2023 17:43
@lyonsil lyonsil merged commit c61e80f into main Oct 23, 2023
7 checks passed
@lyonsil lyonsil deleted the tech-demo-2023-11 branch October 23, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create fork/branch for Tech Demo and remove test code
2 participants