Add locking around key handle operations in mbed provider #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hug-dev
reviewed
Oct 15, 2019
src/providers/mbed_provider/mod.rs
Outdated
| @@ -56,13 +57,17 @@ const SUPPORTED_OPCODES: [Opcode; 7] = [ | |||
| Opcode::ListOpcodes, | |||
| ]; | |||
|
|
|||
| const KEY_SLOT_COUNT: isize = 32; | |||
There was a problem hiding this comment.
Is there a way to read that value from the FFI?
There was a problem hiding this comment.
or maybe put it in the constants file instead?
There was a problem hiding this comment.
Not through FFI, as it is not directly exposed in the header files, but I added it in the constants file.
| pub struct MbedProvider { | ||
| // When calling write on a reference of key_id_store, a type | ||
| // std::sync::RwLockWriteGuard<dyn ManageKeyIDs + Send + Sync> is returned. We need to use the | ||
| // dereference operator (*) to access the inner type dyn ManageKeyIDs + Send + Sync and then | ||
| // reference it to match with the method prototypes. | ||
| key_id_store: Arc<RwLock<dyn ManageKeyIDs + Send + Sync>>, | ||
| local_ids: RwLock<LocalIdStore>, | ||
| key_handle_mutex: Mutex<()>, |
There was a problem hiding this comment.
Maybe it would be nice to add a comment on top of those lines to explain why the Mutex, Semaphore are needed. Just as an help for future code readers.
|
It would be nice, prior to this PR, to make another one that adds the stress test to the CI (and the |
This commit adds locking around the operations that deal with allocating or closing key handles in the mbed provider. Said calls are not thread safe, so a mutex protects access to the calls and a semaphore limits the number of threads that can hold key slots. Change-Id: Icbcad5c05179275d2138d830b33e43976329e931 Signed-off-by: Ionut Mihalcea <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mutex around create, open and close key operations.
Add a semaphore to wrap all function call that use keys.
Fixes #40