Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key handle manipulation is not thread-safe in Mbed Crypto #40

Closed
ionut-arm opened this issue Oct 15, 2019 · 0 comments · Fixed by #41
Closed

Key handle manipulation is not thread-safe in Mbed Crypto #40

ionut-arm opened this issue Oct 15, 2019 · 0 comments · Fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@ionut-arm
Copy link
Member

As mentioned here, Mbed Crypto is not yet thread safe when it comes to allocating or releasing key slots.
This came out of our own stress tests as well, with the service failing to handle requests or tripping over in a segmentation fault. The underlying problem was that all the threads processing requests were getting the same key slot allocated (number 32) and were modifying each other's keys.

This issue should be addressed by hiding the calls to create, open or close a key behind a mutex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants