Added x and y to the type on HTMLOptions #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems related to #2886. Could you maybe update the JSDoc comment as well and check which options are unused as described in my comment? |
@HackbrettXXX I have updated the documentation to include x and y. |
HackbrettXXX
requested changes
Sep 2, 2020
@HackbrettXXX No worries, should be sorted in latest revision |
HackbrettXXX
approved these changes
Sep 3, 2020
|
Thanks, merging it ;) |
|
Do you know when the next release will be @HackbrettXXX? |
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when using the library that it accepts x and y on
.htmlas options however these are not in the types on HTMLOptions.