Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jspdf from 1.4.1 to 2.3.1 #410

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Mar 12, 2021

Bumps jspdf from 1.4.1 to 2.3.1.

Release notes

Sourced from jspdf's releases.

v2.3.1

Small bugfixes. Thanks to all contributors!

  • #3073: fix HTMLAnchorElement is not defined in file saver
  • #3078: fix exception in getTextDimensions() with maxWidth set
  • #3087: fix typings of table() function
  • #3091: fix ReDos vulnerability in addImage function
  • #3099: improve documentation of output function

v2.3.0

A couple of bugfixes, improved font handling and faster compression.

  • #3026: Fix alignment of links created with textWithLink
  • #3032: Fix alignment of table headers
  • #3062: Fix a bug where the options.flags parameter was ignored by the text method and consequently had the wrong defaults. This lead to garbled characters sometimes and was a regression to 1.5.3.
  • #3014: Add typings for internal events API
  • #3036: Support for numeric font weights and separation of font weight and font style
  • #3040: New fontFaces option for the html method that allows to add fonts similar CSS @font-face rules (no addFont calls required anymore). When supplied, fonts are resolved using the CSS 3 font loading algorithm.
  • #3054: replace pako library with fflate leading to faster compression and smaller bundle sizes.

v2.2.0

Incorporates many of the awesome contributions in context of the Hacktoberfest. Thanks to all the contributors!

  • #2944: Fix PDF compression. Special thanks to @​markotaht!
  • #2959: Add support for PDF encryption. Special thanks to @​owenl131!
  • #3018: Fix font name escaping
  • #3017: Fix dependencies in bower.json
  • #3014: Added typings for the events API
  • #2982: Bump dompurify version to fix cve-2020-7691
  • #2981: Fix Canvg import
  • #2946: Remove API, that was removed in the 2.0.0 release, also from the typings
  • #2943: Fix links on pages with different size than the first page
  • #2942: Fix multiline texts in combination with the maxWidth text option
  • #2933, #3021: Fix typings of exported types like ImageCompression
  • #2915: Fix documentation of text method
  • #2906: Fix "Could not load <module>" error messages
  • #2905: Fix usages of atob/btoa in Internet Explorer and "old Edge"

v2.1.1

  • #2893, #2880: Fixed html() typings and JSDoc documentation
  • #2884: Fix type of events in typings
  • #2881: Fix building jsPDF with Parcel v2

v2.1.0

  • #2865: Fix "Critical dependency: the request of a dependency is an expression" warning and loading of optional dependencies
  • #2872: Add support for numbers in cell module
  • #2866: Fix XREF table generation
  • #2855: Fix PdfJS output filename
  • #2848: Fix getTextDimensions typings
  • Updated readme

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 12, 2021
@janlucaklees
Copy link

Would resolve #411. Is there any way I can help, so that this can get merged soon?

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jspdf-2.3.1 branch from 9cf2af5 to ccb3444 Compare April 25, 2021 12:52
@lattam
Copy link

lattam commented May 19, 2021

@janlucaklees While waiting for the fix to be merged and published on npm, you can install the lib using direct URL of this commit

"html2pdf.js": "git+https://github.com/eKoopmans/html2pdf.js.git#ccb3444d461844bd4949eb1f698a693af2bab17a",

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jspdf-2.3.1 branch from ccb3444 to 0ccfc32 Compare July 9, 2021 21:24
@kwisatz
Copy link

kwisatz commented Jul 23, 2021

Any reason in particular @eKoopmans this PR doesn't get merged? We've been using it successfully in production and having to refer to that specific commit from dependent libraries is a hassle.

@kwisatz
Copy link

kwisatz commented Jul 23, 2021

Any reason in particular @eKoopmans this PR doesn't get merged? We've been using it successfully in production and having to refer to that specific commit from dependent libraries is a hassle.

Never mind, just saw this is a duplicate of #419 where an explanation has been given

@eKoopmans
Copy link
Owner

👍 yep, still working on the switch to webpack, having trouble getting it to play nicely with karma right now.

@bouffekai
Copy link

I'm trying to install the package with the specific commit with npm :
"html2pdf.js": "git+https://github.com/eKoopmans/html2pdf.js.git#ccb3444d461844bd4949eb1f698a693af2bab17a",

but I only get this error message :

Command failed: git checkout ccb3444d461844bd4949eb1f698a693af2bab17a
fatal: reference is not a tree: ccb3444d461844bd4949eb1f698a693af2bab17a

Does anyone know why ?

Thank for your help !

@kwisatz
Copy link

kwisatz commented Aug 10, 2021 via email

@bouffekai
Copy link

@eKoopmans is this commit still available ?

@eKoopmans
Copy link
Owner

Hello! The commit is still there I believe; the "fatal: reference is not a tree" is related to npm and package-lock.json I believe, you can see here:

https://stackoverflow.com/a/53250279/4080966

That said, I don't recommend using this commit directly... It will probably work when using html2pdf.js as an import, but I can guarantee it won't work if you try to build it e.g. with npm run build.

I've almost finished a fix to update the jsPDF dependency to v2 and keep everything working correctly. It's required switching bundlers (to Webpack) and adding functionality to the required testing plugins, specifically to get Webpack to play nice with Karma. Like I said, close... Hoping to have it released by end of this week.

@bouffekai
Copy link

@eKoopmans Any update on this matter?

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Aug 31, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/jspdf-2.3.1 branch August 31, 2021 05:06
@eKoopmans
Copy link
Owner

Hi everyone, v0.10.0 is now released with all security audits patched. You can access it by updating your dependencies to "html2pdf.js": "^0.10.0" - since the caret locks to a minor version for 0.x releases.

@bouffekai
Copy link

@eKoopmans i tried to update your package but now I get this error :
Cannot set property 'getPageSize' of undefined

This error come from here :

let opt = {
                margin: 0,
                filename: this.$route.params.agency+'.pdf',
                image: { type: 'png'},
                html2canvas: { dpi: 192, letterRendering: true, imageTimeout : 0, scale:2, backgroundColor : null, 
                                width:800, windowWidth:990, x:95},
                jsPDF: { unit: 'in', format: 'a4', orientation: 'portrait' }
            }
            
            html2pdf().set(opt).from(element).save().catch(function(err){
                console.log(err)
            })

Can you help me ?

Thank you

@eKoopmans
Copy link
Owner

@bouffekai this issue is related to #464, I'm about to release a fix tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants