-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump jspdf from 1.4.1 to 2.3.1 #410
Conversation
Would resolve #411. Is there any way I can help, so that this can get merged soon? |
9cf2af5
to
ccb3444
Compare
@janlucaklees While waiting for the fix to be merged and published on npm, you can install the lib using direct URL of this commit
|
Bumps [jspdf](https://github.com/MrRio/jsPDF) from 1.4.1 to 2.3.1. - [Release notes](https://github.com/MrRio/jsPDF/releases) - [Changelog](https://github.com/MrRio/jsPDF/blob/master/RELEASE.md) - [Commits](parallax/jsPDF@v1.4.1...v2.3.1) Signed-off-by: dependabot[bot] <[email protected]>
ccb3444
to
0ccfc32
Compare
Any reason in particular @eKoopmans this PR doesn't get merged? We've been using it successfully in production and having to refer to that specific commit from dependent libraries is a hassle. |
Never mind, just saw this is a duplicate of #419 where an explanation has been given |
👍 yep, still working on the switch to webpack, having trouble getting it to play nicely with karma right now. |
I'm trying to install the package with the specific commit with npm : but I only get this error message :
Does anyone know why ? Thank for your help ! |
We had the same problem. It appeared that the given revision no longer existed, but then I'm not entirely sure after all.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
@eKoopmans is this commit still available ? |
Hello! The commit is still there I believe; the "fatal: reference is not a tree" is related to npm and https://stackoverflow.com/a/53250279/4080966 That said, I don't recommend using this commit directly... It will probably work when using html2pdf.js as an import, but I can guarantee it won't work if you try to build it e.g. with I've almost finished a fix to update the jsPDF dependency to v2 and keep everything working correctly. It's required switching bundlers (to Webpack) and adding functionality to the required testing plugins, specifically to get Webpack to play nice with Karma. Like I said, close... Hoping to have it released by end of this week. |
@eKoopmans Any update on this matter? |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Hi everyone, v0.10.0 is now released with all security audits patched. You can access it by updating your dependencies to |
@eKoopmans i tried to update your package but now I get this error : This error come from here :
Can you help me ? Thank you |
@bouffekai this issue is related to #464, I'm about to release a fix tonight. |
Bumps jspdf from 1.4.1 to 2.3.1.
Release notes
Sourced from jspdf's releases.
... (truncated)
Commits
9b8f1e9
2.3.120f271a
Docs: improve output documentation (#3099)d8bb3b3
fix ReDoS-vulnerable regexp in addImage (#3091)c91995d
Fix: Wrong TypeScript type in jsPDF.table (#3086) (#3087)3592fc2
fix: scope is not defined in getTextDimensions (#3078)ef70f92
fix(FileSaver): HTMLAnchorElement is not defined (#3073)63f89d4
update package-lock.json (#3065)53ca33b
2.3.0102f370
Merge pull request #3062 from HackbrettXXX/fix-text-encoding-flagsb686db7
fix text encoding flagsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.