Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace reth BlobTransactionSidecar with alloy's #8135

Merged
merged 7 commits into from
May 7, 2024

Conversation

guha-rahul
Copy link
Contributor

@guha-rahul guha-rahul commented May 7, 2024

addresses #8081
When i am deleting

impl<'a> arbitrary::Arbitrary<'a> for BlobTransactionSidecar {
and the
impl proptest::arbitrary::Arbitrary for BlobTransactionSidecar {

i am getting 3 errors of these kind

  --> crates/primitives/src/transaction/mod.rs:94:10
   |
94 | pub enum Transaction {
   |          ^^^^^^^^^^^ the trait `_IMPL_ARBITRARY_FOR_Withdrawals::_proptest::arbitrary::Arbitrary` is not implemented for `alloy_consensus::TxEip4844`
   |

deleting #[derive_arbitrary(compact)] gives a whole barage barage of errors.
@mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this was almost complete, just made it compile and cleaned up some features

@mattsse mattsse marked this pull request as ready for review May 7, 2024 12:05
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label May 7, 2024
@mattsse mattsse enabled auto-merge May 7, 2024 12:26
@mattsse mattsse added this pull request to the merge queue May 7, 2024
Merged via the queue into paradigmxyz:main with commit cbc6f26 May 7, 2024
29 checks passed
mw2000 pushed a commit to mw2000/reth that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants