replace reth BlobTransactionSidecar with alloy's

[mattsse]

Describe the feature

with this alloy-rs/alloy#677

we can remove this entirely:

reth/crates/primitives/src/transaction/sidecar.rs

Lines 309 to 319 in ead753d

	/// This represents a set of blobs, and its corresponding commitments and proofs.
	#[derive(Clone, Debug, PartialEq, Eq, Default, Serialize, Deserialize)]
	#[repr(C)]
	pub struct BlobTransactionSidecar {
	/// The blob data.
	pub blobs: Vec<Blob>,
	/// The blob commitments.
	pub commitments: Vec<Bytes48>,
	/// The blob proofs.
	pub proofs: Vec<Bytes48>,
	}

and this implementation as well

reth/crates/primitives/src/transaction/eip4844.rs

Lines 118 to 123 in ead753d

	#[cfg(feature = "c-kzg")]
	pub fn validate_blob(
	&self,
	sidecar: &BlobTransactionSidecar,
	proof_settings: &KzgSettings,
	) -> Result<(), BlobTransactionValidationError> {

Additional context

No response

[mahesh-dalle]

hey there, is the issue open or blocked by the alloy pr?

[mattsse]

should be ready now, last blocker is possibly alloy-rs/alloy#679 but doesn't impact changes just --all-features compilation

do you want to take this?

first we need to bump the alloy deps here and https://github.com/paradigmxyz/evm-inspectors

[mahesh-dalle]

Yes, i would like to try this.

[mattsse]

nice, if you have any questions etc, please open a draft pr and we take it from there

[mahesh-dalle]

Well, before opening a draft can u please dump as many pointers as you can. Also from what i understand , we need to delete the struct and all the impls related to it what do we exactly import from alloy for BlobTransactionSidecar?, also we need to delete the validate_blob function and import it from alloy_consensus right?

[mattsse]

we need to delete the struct and all the impls related to it what do we exactly import from alloy for BlobTransactionSidecar?, also we need to delete the validate_blob function and import it from alloy_consensus right?

yes to all of this

[mahesh-dalle]

we need to delete the struct and all the impls related to it what do we exactly import from alloy for BlobTransactionSidecar?, also we need to delete the validate_blob function and import it from alloy_consensus right?

yes to all of this
Do we need this ?
impl proptest::arbitrary::Arbitrary for BlobTransactionSidecar and BlobTransactionSidecarRlp ?
cuz i am getting an error after removing the struct and impl for BlobTransactionSidecar.

error[E0117]: only traits defined in the current crate can be implemented for types defined outside of the crate
   --> crates/primitives/src/transaction/sidecar.rs:468:1
    |
468 | impl proptest::arbitrary::Arbitrary for BlobTransactionSidecar {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------
    | |                                       |
    | |                                       `reth_rpc_types::BlobTransactionSidecar` is not defined in the current crate
    | impl doesn't use only types from inside the current crate
    |
    = note: define and implement a trait or new type instead

error[E0117]: only traits defined in the current crate can be implemented for types defined outside of the crate
   --> crates/primitives/src/transaction/sidecar.rs:443:1
    |
443 | impl<'a> arbitrary::Arbitrary<'a> for BlobTransactionSidecar {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------
    | |                                     |
    | |                                     `reth_rpc_types::BlobTransactionSidecar` is not defined in the current crate
    | impl doesn't use only types from inside the current crate
    |
    = note: define and implement a trait or new type instead
    ```

[mattsse]

this is merged now:

alloy-rs/alloy#677

[mahesh-dalle]

Hey i dont think i would be able to continue on this one. Will be out on a lookout for more easier GFIs.

[guha-rahul]

submitting a pr on this issue then.