feat: enable optimism hardforks on genesis parse #7935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
mattsse
requested changes
Apr 29, 2024
crates/primitives/src/chain/spec.rs
Outdated
Comment on lines
1045
to
1059
| #[cfg(feature = "optimism")] | ||
| ( | ||
| Hardfork::Regolith, | ||
| genesis.config.extra_fields.get("regolithTime").and_then(|value| value.as_u64()), | ||
| ), | ||
| #[cfg(feature = "optimism")] | ||
| ( | ||
| Hardfork::Ecotone, | ||
| genesis.config.extra_fields.get("ecotoneTime").and_then(|value| value.as_u64()), | ||
| ), | ||
| #[cfg(feature = "optimism")] | ||
| ( | ||
| Hardfork::Canyon, | ||
| genesis.config.extra_fields.get("canyonTime").and_then(|value| value.as_u64()), | ||
| ), |
There was a problem hiding this comment.
this works, but perhaps we could make this reusable by adding a helper struct that contains all the activation info as Optional fields and has a OptimsismGenesisInfo::extract_from(&Genesis) or similar
There was a problem hiding this comment.
sure done here 1a781c3 PTAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7043, Closes #7702
Modifies the
From<Genesis>implementation ofChainSpecto take into account the Optimism hardfork info inextra_fields.