Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OptimismGenesis fields type #7702

Closed
mattsse opened this issue Apr 17, 2024 · 4 comments · Fixed by #7935
Closed

Add OptimismGenesis fields type #7702

mattsse opened this issue Apr 17, 2024 · 4 comments · Fixed by #7935
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Apr 17, 2024

Describe the feature

Optimism includes additional info in the genesis file.

we don't want to pollute the eth genesis bindings with these, instead we should bundle them in a separate type:

See for example:

https://raw.githubusercontent.com/paradigmxyz/alphanet/331aaea21649e1295d676b73a4ce206bbfbdfe04/crates/testing/resources/etc/genesis.json

This includes OP timestamps + optimism object

This type can be added to node-optimism crate for now

cc @fgimenez

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Apr 17, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Apr 17, 2024
@andrzejSulkowski
Copy link
Contributor

I'd like to try this one

@andrzejSulkowski
Copy link
Contributor

It's the first time I will be contributing to this repo and my second time in total so I just would like to clarify quickly...
Steps to tackle this issue are:

  1. Identify differences between the genesis file of optimism and eth
  2. Extract the differences into a separate type (inside node-optimism crate)

Thank you in advance!

@fgimenez
Copy link
Member

hey @andrzejSulkowski this task is blocking other areas of work and it is already in progress, sorry for not updating its state.

pls take a look at other good first issues to work on! D-good-first-issue Nice and easy! A great choice to get started

@fgimenez fgimenez removed the D-good-first-issue Nice and easy! A great choice to get started label Apr 24, 2024
@fgimenez fgimenez moved this from Todo to In Progress in Reth Tracker Apr 24, 2024
@fgimenez fgimenez self-assigned this Apr 24, 2024
@Jrachman
Copy link

Jrachman commented Apr 24, 2024

temporary solution i put together that programmatically launches the dev node with custom genesis updates: https://github.com/otim-xyz/alphanet/blob/main/examples/custom-genesis-dev-node.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants