Verify tx response data against request #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
emhane/speed-up-request-buffered-hashes
to
main
February 13, 2024 19:08
emhane
force-pushed
the
emhane/validate-tx-response
branch
from
482c157
to
31d2a5e
Compare
mattsse
requested changes
Feb 18, 2024
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Matthias Seitz <[email protected]>
…reth into emhane/validate-tx-response
emhane
force-pushed
the
emhane/validate-tx-response
branch
from
32c3736
to
963012b
Compare
emhane
force-pushed
the
emhane/one-req-per-peer-bottleneck
branch
from
573f333
to
358f3ac
Compare
mattsse
requested changes
Feb 23, 2024
emhane
changed the base branch from
emhane/one-req-per-peer-bottleneck
to
main
onbjerg
approved these changes
Feb 27, 2024
|
|
||
| let unvalidated_payload_len = verified_payload.len(); | ||
|
|
||
| // todo: report peer for sending invalid response |
There was a problem hiding this comment.
yeah exactly can add which issues it depends on
| @@ -972,6 +983,8 @@ where | |||
| return | |||
| } | |||
|
|
|||
| let mut transactions = transactions.0; | |||
There was a problem hiding this comment.
Should we impl deref etc on PooledTransactions?
There was a problem hiding this comment.
yeah sure, Deref is always safe, DerefMut you have to be sure this doesn't effect existing behaviour. usually only do it on my own new types cause of this.
There was a problem hiding this comment.
anyhow, out of scope of pr I think
Co-authored-by: Oliver Nordbjerg <[email protected]>
Co-authored-by: Oliver Nordbjerg <[email protected]>
…reth into emhane/validate-tx-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6438, closes #6396