Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track bad PooledTransactions responses with metrics #6529

Open
1 task done
Tracked by #6527
emhane opened this issue Feb 10, 2024 · 6 comments
Open
1 task done
Tracked by #6527

Track bad PooledTransactions responses with metrics #6529

emhane opened this issue Feb 10, 2024 · 6 comments
Labels
A-devp2p Related to the Ethereum P2P protocol A-networking Related to networking in general A-observability Related to tracing, metrics, logs and other observability tools D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@emhane
Copy link
Member

emhane commented Feb 10, 2024 •
edited
Loading

Describe the feature

Track peers that respond with other transactions than those requested.

Ultimately, this should include transactions that are not of the same size as the announced size, if eth68 metadata is known for the tx hash, since the announced size could be fake. However, the latter could be misleading so long as metadata is not stored as a (peer, size) tuple, #6528, hence can be addressed at a later point.

Depends on #6438.

Additional context

No response

Tasks
Beta Give feedback
  1. Add metrics for observing tx fetch outcome #7401
    A-networking A-observability
@emhane emhane added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started A-devp2p Related to the Ethereum P2P protocol A-networking Related to networking in general A-observability Related to tracing, metrics, logs and other observability tools and removed C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 10, 2024
@emhane emhane mentioned this issue Feb 10, 2024
Open
@Richa-iitr
Copy link

Hey @emhane,
can i take this up?

@emhane
Copy link
Member Author

emhane commented Feb 17, 2024

that would be great @Richa-iitr ! best use #6439 as base branch and incorporate the logic for this issue into the PooledTransactions verification. just finished up the code in lib in my pr, just need to finish up fixing the tests target and lint, so shouldn't be much, if any, merge conflicts for you later.

@Richa-iitr
Copy link

Sure, thanks :)

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Mar 10, 2024
@emhane emhane added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Mar 10, 2024
@emhane
Copy link
Member Author

emhane commented Mar 10, 2024

@Richa-iitr how's it going with this?

@Richa-iitr
Copy link

Hi, i was travelling for the last 2 weeks. Plan to look into this in this week. Hope this works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devp2p Related to the Ethereum P2P protocol A-networking Related to networking in general A-observability Related to tracing, metrics, logs and other observability tools D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emhane @Richa-iitr