chore(deps): migrate to jsonrpsee 0.22 #5894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changelog for 21.0 mentions that a middleware could be used, maybe we could use that let rpc_middleware = RpcServiceBuilder::new().rpc_logger(1024);
let server = Server::builder().set_rpc_middleware(rpc_middleware).build("127.0.0.1:0").await?; |
emhane
added
the
A-dependencies
DaniPopes
changed the title
9 tasks
|
Okay finally pulled through.
actually this can be added with a few more changes, but want to get this pr out of the way first |
mattsse
force-pushed
the
matt/bump-jsonrpsee21
branch
from
0854aa4
to
d04d558
Compare
onbjerg
reviewed
Apr 5, 2024
crates/rpc/rpc-builder/src/lib.rs
Outdated
Comment on lines
1740
to
1745
| // let metrics = modules.ipc.as_ref().map(RpcRequestMetrics::new).unwrap_or_default(); | ||
| let ipc_path = self | ||
| .ipc_endpoint | ||
| .unwrap_or_else(|| Endpoint::new(DEFAULT_IPC_ENDPOINT.to_string())); | ||
| let ipc = builder.set_logger(metrics).build(ipc_path.path())?; | ||
| let ipc = builder | ||
| // .set_middleware(metrics) |
There was a problem hiding this comment.
yep, this needs a few more changes, metrics for ipc are not that important
DaniPopes
approved these changes
Apr 5, 2024
| "rustls", | ||
| "rustls-pemfile", | ||
| "rustls 0.21.10", | ||
| "rustls-pemfile 1.0.4", |
There was a problem hiding this comment.
deduped with #7018 on a future jsonrpsee version
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the latest release of jsonrpsee removes a bunch of logging functionality which breaks our current rpc metrics setup...
not sure how to proceed with this yet