Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set trace result to null if non revert or selfdestruct #3840

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

@mattsse mattsse added the A-rpc Related to the RPC implementation label Jul 18, 2023
@mattsse mattsse requested a review from Rjected July 18, 2023 17:39
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #3840 (a8380c7) into main (0ef68b7) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

Impacted Files Coverage Δ
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.60% <0.00%> (-0.03%) ⬇️
unit-tests 64.02% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.49% <ø> (ø)
blockchain tree 83.02% <ø> (ø)
pipeline 87.04% <ø> (ø)
storage (db) 74.32% <ø> (ø)
trie 94.65% <ø> (ø)
txpool 46.55% <ø> (-0.27%) ⬇️
networking 77.51% <ø> (-0.09%) ⬇️
rpc 58.34% <ø> (ø)
consensus 65.00% <ø> (ø)
revm 33.66% <0.00%> (ø)
payload builder 6.61% <ø> (ø)
primitives 88.06% <ø> (+<0.01%) ⬆️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the

        let result = if action.is_selfdestruct() ||
            (self.trace.is_error() && !self.trace.is_revert())

condition is much easier to understand

@Rjected Rjected added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit b8587a2 Jul 18, 2023
@Rjected Rjected deleted the matt/optional-result branch July 18, 2023 20:30
merklefruit pushed a commit to merklefruit/op-reth-old that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't populate trace_transaction result even if tx reverted
2 participants