Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't populate trace_transaction result even if tx reverted #3834

Closed
mattsse opened this issue Jul 18, 2023 · 0 comments · Fixed by #3840
Closed

Don't populate trace_transaction result even if tx reverted #3834

mattsse opened this issue Jul 18, 2023 · 0 comments · Fixed by #3840
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 18, 2023

Describe the feature

ref

#3678 (comment)

result should be null if out of gas

image

Additional context

No response
@mattsse mattsse added C-bug An unexpected or incorrect behavior C-enhancement New feature or request A-rpc Related to the RPC implementation labels Jul 18, 2023
@mattsse mattsse removed the C-enhancement New feature or request label Jul 18, 2023
@mattsse mattsse mentioned this issue Jul 18, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: set trace result to null if non revert or selfdestruct paradigmxyz/reth
1 participant
@mattsse