-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add support for seeded rng #3270
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3270 +/- ##
==========================================
- Coverage 69.74% 69.74% -0.01%
==========================================
Files 531 531
Lines 71581 71670 +89
==========================================
+ Hits 49927 49985 +58
- Misses 21654 21685 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think we can add a proptest specific env var for setting a seed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
lgtm, pending smol conflict
Adds the ability to set the seed used to generate random test data using an environment variable
SEED
.This should make coverage more deterministic, although our proptests still end up making the results fluctuate a bit even if nothing in the code was changed.
Ref #1344