Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic coverage #1344

Closed
onbjerg opened this issue Feb 14, 2023 · 2 comments
Closed

Deterministic coverage #1344

onbjerg opened this issue Feb 14, 2023 · 2 comments
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test S-stale This issue/PR is stale and will close with no further activity

Comments

@onbjerg
Copy link
Member

onbjerg commented Feb 14, 2023

Describe the feature

We need to replace any test that uses random test data with something deterministic so coverage reports don't fluctuate by +- a few percentage on every PR.

Two paths:

  1. Use fixtures (hard since we need to generate them and make sure they cover all cases)
  2. Use a seeded RNG that we can set for CI

Additional context

No response
@onbjerg onbjerg added C-enhancement New feature or request C-test A change that impacts how or what we test labels Feb 14, 2023
@onbjerg onbjerg mentioned this issue Jun 20, 2023
Merged
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 14, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@onbjerg