fix: use recv timeout if persistence task is active #10087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
the
C-debt
mattsse
force-pushed
the
matt/use-recv-timeout-if-persistence-is-active
branch
from
2055920
to
565a297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9926
this is an easy fix that allows us to handle persistence responses in case we no longer receive an engine message.
previously we were only advancing persistence once we received a new engine message, this now uses the recv_timeout call if there's a persistence action in progress so that we no longer block indefinitely.
I was looking into whether we need to redesign the entire message passing or use crossbeam select, but this is a lot simpler and similar to how crossbeam::Select works anyway.