Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message tree task message model #9926

Closed
Tracked by #8742
mattsse opened this issue Jul 31, 2024 · 0 comments · Fixed by #10087
Closed
Tracked by #8742

Improve message tree task message model #9926

mattsse opened this issue Jul 31, 2024 · 0 comments · Fixed by #10087
Assignees
Labels
C-debt Refactor of code section that is hard to understand or maintain

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jul 31, 2024

Currently we can't handle engine requests and persistence events concurrently because they use two different channels

so we only proceed with handling persistence tasks after we received a new engine message.

these should use a single channel, this means we need to unify both channels and use a superset of event variants

incoming: Receiver<FromEngine<BeaconEngineMessage<T>>>,

so that this is returned over the unified channel

/// Receiver end of channel where the result of the persistence task will be
/// sent when done. A None value means there's no persistence task in progress.
rx: Option<oneshot::Receiver<B256>>,

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Jul 31, 2024
@mattsse mattsse self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant