Report accurate value for max_concurrent_requests #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mud2monarch
commented
Nov 18, 2024
crates/cli/src/parse/source.rs
Outdated
| use super::*; | ||
| use thousands::Separable; | ||
|
|
||
| async fn setup_source(max_concurrent_requests: u64) -> Source { |
There was a problem hiding this comment.
this is taken from parse::timestamps except I set the max_concurrent_requests to the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #200
Motivation
Fixing issue #200
Solution
parse_source()currently setsmax_concurrent_requeststoargs.requests_per_second. This leads to an inaccurate reporting of the actual value ofmax_concurrent_requests, set in lines 50 and 57.PR Checklist