You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Platform
M1 MBP on Sonoma 14.6.1
output of uname -a: Darwin CORN-Zach-913.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000 arm64
Description
It appears that a user's max concurrent requests setting is mis-assigned to the user's requests-per-second setting.
I tried this code:
I expected max concurrent requests to be set to 10 in both cases, but it was set to whatever value I passed to --requests-per-second.
* Ensure output value for max_concurrent_requests is reported accurately
Fixes issue #200
* small correction. removing map since it's already an Option<u64>
* Added test for PR.
* Update source.rs
* Update Cargo.toml
* Update Cargo.lock
---------
Co-authored-by: Zach Wong <[email protected]>
Co-authored-by: sslivkoff <[email protected]>
Version
0.3.2-11-gc3a2f1d
Platform
M1 MBP on Sonoma 14.6.1
output of uname -a:
Darwin CORN-Zach-913.local 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000 arm64
Description
It appears that a user's max concurrent requests setting is mis-assigned to the user's requests-per-second setting.
I tried this code:
I expected max concurrent requests to be set to 10 in both cases, but it was set to whatever value I passed to
--requests-per-second
.I believe the error code is in source::parse_source().
It currently reads
max_concurrent_requests: args.requests_per_second.map(|x| x as u64)
but should be changed to
max_concurrent_requests: args.max_concurrent_requests.map(|x| x as u64)
I'll open a PR. Should I add tests? This is my first time contributing to anything so appreciate guidance.
The text was updated successfully, but these errors were encountered: