Pin jupyter transitive deps in integration tests #6568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not seem to jive with the depending target above which has a python 3 compatibility constraint. |
|
Mm. I tested that it fixed the broken test, but didn't go much further. Now running the whole suite locally. |
jsirois
approved these changes
Sep 27, 2018
|
Will merge on green for the first commit. |
stuhood
pushed a commit
that referenced
this pull request
Sep 28, 2018
### Problem As described in pex-tool/pex#561, jupyter's transitive deps float. Today that caused breakage. ### Solution Pin the relevant deps (ht John in pex-tool/pex#562).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in pex-tool/pex#561, jupyter's transitive deps float. Today that caused breakage.
Solution
Pin the relevant deps (ht John in pex-tool/pex#562).