Skip to content

Commit

Permalink
Pin jupyter transitive deps in integration tests (#6568)
Browse files Browse the repository at this point in the history
### Problem

As described in pex-tool/pex#561, jupyter's transitive deps float. Today that caused breakage.

### Solution

Pin the relevant deps (ht John in pex-tool/pex#562).
  • Loading branch information
Stu Hood authored Sep 28, 2018
1 parent 0d4cd70 commit 56cb981
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,17 @@ python_binary(
]
)

# Without blacklisting, pex resolver will error out
# on a transitive requirement of jupyter (functools32)
# when resolving for Python 3.
# This library requires pex blacklisting under python 3, because the pex resolver will error out
# on a transitive requirement of jupyter (functools32).
#
# This test also runs under python 2 though, and so in order to avoid dep floats of jupyter's
# transitive deps (which can float upward to versions that do not support python 2), we pin them.
python_requirement_library(
name='reqlib',
requirements=[
python_requirement('jupyter'),
python_requirement('jupyter==1.0.0'),
python_requirement('ipykernel<5'),
python_requirement('ipython<6'),
]
)

Expand Down

1 comment on commit 56cb981

@mateor
Copy link
Member

@mateor mateor commented on 56cb981 Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do this internally myself ;)

Please sign in to comment.