nfpm: Improve clarity of test names and where to packager fields #21310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
added
category:internal
cognifloyd
force-pushed
the
cognifloyd/nfpm-clarify
branch
from
cf5fbd4
to
a3eb4d2
Compare
tdyas
approved these changes
Aug 15, 2024
This should make the organization of fields more straightforward.
cognifloyd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the scripts fields into the
<packager>_FIELDSconstants to satisfy this review suggestions:#21299 (comment)
#21310 (comment)
It also adds
param.pytest(..., id="...")to name tests in a sane way. I noticed this while splitting up the nfpm PR into multiple PRs, but implementing it across so many PRs would have been painful. So, I saved it for this follow-up PR.