-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pants upgrade from 2.22.0 to 2.23.0a0 #6229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
PR that changes 100-499 lines. Requires some effort to review.
label
Aug 5, 2024
cognifloyd
force-pushed
the
pants-upgrade-2.23
branch
from
August 7, 2024 19:12
c04bdf7
to
b7b39be
Compare
pull-request-size
bot
added
size/XL
PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
and removed
size/L
PR that changes 100-499 lines. Requires some effort to review.
labels
Aug 7, 2024
cognifloyd
force-pushed
the
pants-upgrade-2.23
branch
from
September 9, 2024 22:44
b7b39be
to
d734d37
Compare
pull-request-size
bot
added
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
and removed
size/XL
PR that changes 500-999 lines. Consider splitting work into several ones that easier to review.
labels
Sep 9, 2024
cognifloyd
force-pushed
the
pants-upgrade-2.23
branch
from
September 10, 2024 15:22
d734d37
to
9e91160
Compare
pull-request-size
bot
added
size/L
PR that changes 100-499 lines. Requires some effort to review.
and removed
size/XXL
PR that changes 1000+ lines. You should absolutely split your PR into several.
labels
Sep 10, 2024
guzzijones
approved these changes
Sep 12, 2024
Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pantsbuild-pants 2.22.0 --> 2.23.0a0 pantsbuild-pants-testutil 2.22.0 --> 2.23.0a0 pex 2.3.1 --> 2.16.2 typing-extensions 4.3.0 --> 4.12.2 == Added dependencies == libcst 1.4.0
It is now a per-resolve option: [export].py_non_hermetic_scripts_in_resolve = ["st2"]
cognifloyd
force-pushed
the
pants-upgrade-2.23
branch
from
September 12, 2024 18:50
9e91160
to
0046645
Compare
cognifloyd
changed the title
Pants upgrade from 2.20.3 to 2.23
Pants upgrade from 2.22.0 to 2.23.0a0
Sep 12, 2024
Once pants can build our packages, all of the dist_utils bits should be deleted.
This facilitates running just the pack tests via pants using: pants --tag=pack test ::
guzzijones
approved these changes
Sep 13, 2024
amanda11
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure: ci/cd
pantsbuild
size/L
PR that changes 100-499 lines. Requires some effort to review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates from pants 2.22 to 2.23. The stable version of 2.23 has not been released yet, but with so many features that we need, it's worth using an alpha to unblock other developments.
I also added a
.gitattributes
file to try and improve the UX of fixing lockfile merge conflicts.I also included 2 minor commits extracted from #6202:
dist_utils.py
, so also ignoretest_dist_utils.py
: 4234724tags=["pack"]
to all of the pack tests so that we can easily run just the pack tests via pants: 77ee17cFollow-up PRs will allow us to run all of the pack and unit tests via pants + pytest.
Interesting new features in 2.23
The
[export].py_hermetic_scripts
option is renamed to[export].py_non_hermetic_scripts_in_resolve
in 2.23:This release adds the last 2 features we need from pants to get pants+pytest to run all of our unit and pack tests, based on work in #6202:
Added a
python_test(entry_point_dependencies={...})
BUILD metadata field. This field was added to resolve issues enabling our runner tests (released in 2.23.0.dev2): Generate entry_points.txt for python_tests that require entry points from a python_distribution pantsbuild/pants#21062Added a pants plugin api
PytestPluginSetup(extra_sys_path=...)
which we need to finish some pack_metadata based dependency inference (released in 2.23.0a0): AddPytestPluginSetup.extra_sys_path
for pants-plugins pantsbuild/pants#21274v2.23.0a0 also includes the
nfpm
plugin I wrote to replace ourst2-packaging
repo.nFPM
builds system packages like rpm and deb without the complicated ruby+docker+the-kitchen-sink dance we do inst2-packaging
.pants-plugins lockfile diffs
From 2.22 to 2.23