fix: in-repo plugin requirements.txt not loading (Cherry-pick of #20355) #20381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the change that was introduced on #19406: Due to the fact sys.path was not yet altered, `_collect_backends_requirements` fails to load in-repo plugins, thus ignoring the requirements.txt file. --------- Co-authored-by: Idan Attias <[email protected]>
|
It looks like feature was released with this issue in 2.18.0. We're very close to 2.19.0, and it'd be good to finalise the branch, and existing bugs like this don't seem important enough to be worth delaying (whereas a regression from 2.18 to 2.19 would be worth delaying). As such, I'm suggesting we hold off on merging this until 2.19.1 (which we can do fairly soon after 2.19.0), and will mark it as a draft to match. Let me know if you disagree, and we can discuss. |
|
@huonw yea thanks, totally agree. |
|
@huonw Just making sure we're not forgetting about this one :) |
kaos
approved these changes
Jan 29, 2024
|
2.19.0 is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the change that was introduced on #19406: Due to the fact sys.path was not yet altered,
_collect_backends_requirementsfails to load in-repo plugins, thus ignoring the requirements.txt file.