fix: in-repo plugin requirements.txt not loading #20355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed the change that was introduced on pantsbuild#19406: Due to the fact sys.path was not yet altered, `_collect_backends_requirements` fails to load in-repo plugins, thus ignoring the requirements.txt file.
|
@kaos Unfortunately the original PR had an issue :( Thanks |
|
Is this something we can add a regression test for? |
|
I’m not sure, maybe you’ll have a suggestion. The problem only occurs when you try to load a in-repo plugin that has 3rd party dependencies, and it’s path is not already in sys.path |
This fixed the change that was introduced on pantsbuild#19406: Due to the fact sys.path was not yet altered, `_collect_backends_requirements` fails to load in-repo plugins, thus ignoring the requirements.txt file.
kaos
approved these changes
Jan 9, 2024
|
Thanks for approving! I've updated the existing test to reflect the change, so we're covered :) |
WorkerPants
pushed a commit
that referenced
this pull request
Jan 9, 2024
This fixes the change that was introduced on #19406: Due to the fact sys.path was not yet altered, `_collect_backends_requirements` fails to load in-repo plugins, thus ignoring the requirements.txt file. --------- Co-authored-by: Idan Attias <[email protected]>
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.19.xSuccessfully opened #20381. Thanks again for your contributions! |
kaos
pushed a commit
that referenced
this pull request
Jan 29, 2024
…) (#20381) This fixes the change that was introduced on #19406: Due to the fact sys.path was not yet altered, `_collect_backends_requirements` fails to load in-repo plugins, thus ignoring the requirements.txt file. Co-authored-by: Idan Attias <[email protected]> Co-authored-by: Idan Attias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the change that was introduced on #19406: Due to the fact sys.path was not yet altered,
_collect_backends_requirementsfails to load in-repo plugins, thus ignoring the requirements.txt file.