Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the 2.17.0rc1 release. #19276

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Jun 8, 2023

No description provided.

@benjyw benjyw added the category:internal CI, fixes for not-yet-released features, etc. label Jun 8, 2023
@benjyw benjyw requested review from thejcannon, kaos and alonsodomin June 8, 2023 17:30
@kaos
Copy link
Member

kaos commented Jun 8, 2023

I wonder why this was labeled internal, when the ticket it closed was labeled as bug?

@kaos
Copy link
Member

kaos commented Jun 8, 2023

same for this one, even a comment in the PR about being a bugfix.

Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes in order to address my two comments before merging.

@benjyw benjyw requested a review from kaos June 8, 2023 18:12
@benjyw benjyw merged commit 4d8508b into pantsbuild:main Jun 8, 2023
@benjyw benjyw deleted the prepare_2.17.0rc1 branch June 8, 2023 19:05
benjyw added a commit that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants