Fix secondary ownership warning semantics (Cherry-pick of #19191) #19224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #19174 by boiling the criteria to warn down to: 1. The Address/Target/FieldSet is matched due __only__ to `SecondaryOwnerMixin` 2. It was matched due to a file spec (literal or glob) 3. It wasn't matched due ton address spec - This is just to handle the corner case where it was matched due to file and address In order to facilitate 1., `Owner` and `find_owner` have been (temporarily) modified. Additionally, the rule that goes from `RawSpecsWithOnlyFileOwners` -> `Addresses` has been split to return `Owners`, with an additional rule added to complete the graph (`Owners` -> `Addresses`). Then 2 and 3 are facilitated by just requesting the addresses based on the include specs.
thejcannon
added
the
category:internal
stuhood
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19174 by boiling the criteria to warn down to:
SecondaryOwnerMixinIn order to facilitate 1.,
Ownerandfind_ownerhave been (temporarily) modified. Additionally, the rule that goes fromRawSpecsWithOnlyFileOwners->Addresseshas been split to returnOwners, with an additional rule added to complete the graph (Owners->Addresses).Then 2 and 3 are facilitated by just requesting the addresses based on the include specs.