Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update env:deploy ACs #1238

Closed
wants to merge 1 commit into from
Closed

Update env:deploy ACs #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/newfeatures/env-deploy.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Feature: Site Deployment

@vcr site_deploy
Scenario: Deploy dev to test
When I run "terminus env:deploy test --site=[[test_site_name]] --sync-content --note='Deploy test'"
When I run "terminus env:deploy [[test_site_name]].test 'Deploy log note' --sync-content"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ari-gold: Is the deploy log note optional? If it is I think I would keep the --note|-n flag so that the position of optional arguments is not significant... it could be specified before or after --sync-content which is also optional. If --note is not optional then I'm +1 on this arg layout.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... but I am not -1 on the way it is now :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Rather don't change the notes since that requires recording new fixtures.
  • I agree with Adam, if it's optional it should be an option, and existing functionality has the note default to "Deploy from Terminus" so it's currently optional.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreeing with @ajbarry and @marktheunissen, the note should be an option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested existing functionality the note was required:

$ terminus site deploy --env=test --site=aaa-ari
Custom note for the deploy log: 
Custom note for the deploy log: 
Custom note for the deploy log: 
Custom note for the deploy log: 
Custom note for the deploy log: 
Custom note for the deploy log:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ari-gold Terminus requires it now, but the API does not require it. Why be beholden to the old pattern?
https://github.com/pantheon-systems/titan-mt/blob/master/yggdrasil/yggdrasil_workflows.py#L4448

Then I should get "."
And I should get "."
Then I should get:
Expand All @@ -19,12 +19,12 @@ Feature: Site Deployment

@vcr site_deploy_no_changes
Scenario: Failing to deploy dev to test because there are no changes to deploy
When I run "terminus env:deploy test --site=[[test_site_name]] --sync-content --note='Deploy test'"
When I run "terminus env:deploy [[test_site_name]].test 'Deploy log note' --sync-content"
Then I should get: "There is nothing to deploy."

@vcr site_init-env
Scenario: Initializing test when it has not been previously initialized
When I run "terminus env:deploy test --site=[[test_site_name]] --sync-content --note='First deploy to live'"
When I run "terminus env:deploy [[test_site_name]].test 'First deploy' --sync-content"
Then I should get "."
And I should get "."
Then I should get:
Expand Down