Update env:deploy ACs #1238
Update env:deploy ACs #1238
Conversation
- Update site and env flags to a single argument in the form <site>.<env> - Update required deploy note from flag to argument
|
@ari-gold, thanks for your PR! By analyzing the blame information on this pull request, we identified @TeslaDethray to be a potential reviewer |
| @@ -9,7 +9,7 @@ Feature: Site Deployment | |||
|
|
|||
| @vcr site_deploy | |||
| Scenario: Deploy dev to test | |||
| When I run "terminus env:deploy test --site=[[test_site_name]] --sync-content --note='Deploy test'" | |||
| When I run "terminus env:deploy [[test_site_name]].test 'Deploy log note' --sync-content" | |||
There was a problem hiding this comment.
@ari-gold: Is the deploy log note optional? If it is I think I would keep the --note|-n flag so that the position of optional arguments is not significant... it could be specified before or after --sync-content which is also optional. If --note is not optional then I'm +1 on this arg layout.
There was a problem hiding this comment.
... but I am not -1 on the way it is now :-)
There was a problem hiding this comment.
- Rather don't change the notes since that requires recording new fixtures.
- I agree with Adam, if it's optional it should be an option, and existing functionality has the note default to "Deploy from Terminus" so it's currently optional.
There was a problem hiding this comment.
Agreeing with @ajbarry and @marktheunissen, the note should be an option.
There was a problem hiding this comment.
When I tested existing functionality the note was required:
$ terminus site deploy --env=test --site=aaa-ari
Custom note for the deploy log:
Custom note for the deploy log:
Custom note for the deploy log:
Custom note for the deploy log:
Custom note for the deploy log:
Custom note for the deploy log:
There was a problem hiding this comment.
@ari-gold Terminus requires it now, but the API does not require it. Why be beholden to the old pattern?
https://github.com/pantheon-systems/titan-mt/blob/master/yggdrasil/yggdrasil_workflows.py#L4448
site.env