Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc 11 docker #240

Merged
merged 7 commits into from
Nov 1, 2022
Merged

gcc 11 docker #240

merged 7 commits into from
Nov 1, 2022

Conversation

ekg
Copy link
Collaborator

@ekg ekg commented Oct 11, 2022

Try to work around build errors with an updated seqwish.

@ekg ekg changed the title Gcc 11 docker gcc 11 docker Oct 11, 2022
@ekg
Copy link
Collaborator Author

ekg commented Oct 11, 2022

@AndreaGuarracino I was trying to get around -mcx16 because it prevents ARM builds.

@AndreaGuarracino
Copy link
Member

AndreaGuarracino commented Oct 15, 2022

I think this post explains what is happening. Indeed, this commit was necessary to be able to build seqwish without the -march=native option. Moreover, also on my laptop, with Ubuntu 22.04 and Intel CPU, I am not able to build the current seqwish's master with the -DCMAKE_BUILD_TYPE=Generic option.

Now, by using this seqwish's commit that forces the -march=haswell option when we build with -DCMAKE_BUILD_TYPE=Generic or -DCMAKE_BUILD_TYPE=Debug (not -DCMAKE_BUILD_TYPE=Release, so without -march=native), we are able to fully build PGGB's Dockerfile with the latest seqwish, but I am not sure if this destroys stuff on ARM systems. I see that with aarch64 ASAN doesn't like the result.

@AndreaGuarracino
Copy link
Member

Building seqwish with -DCMAKE_BUILD_TYPE=Release is the only current way to get it on aarch64 (ekg/seqwish@6bc8c87), so the doubts remain.

@AndreaGuarracino AndreaGuarracino merged commit 3e4205d into master Nov 1, 2022
@subwaystation subwaystation mentioned this pull request Nov 2, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants