Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for groupby.rolling.corr #54499

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Unit test for groupby.rolling.corr #54499

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
91d53ea
unit-test
Aug 11, 2023
3d04bf9
unit_test_2
Aug 11, 2023
4e4763b
u_test update
Aug 11, 2023
9e7c319
rename unit_tests
Aug 11, 2023
4a7620b
Merge branch 'pandas-dev:main' into unit-test
omar-elbaz Aug 11, 2023
2a6a2e3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions pandas/tests/groupby/test_groupby.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3159,3 +3159,29 @@ def test_groupby_series_with_datetimeindex_month_name():
expected = Series([2, 1], name="jan")
expected.index.name = "jan"
tm.assert_series_equal(result, expected)


def test_rolling_corr_grouping_column_contains_tuples_1(df):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move these tests to pandas/tests/window/test_groupby.py in a follow up PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sounds good, will get it in shortly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mroeschke, this is the number for the new pr #54504, I'm just waiting for the checks to clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke the other PR went through please merge :) thanks

# GH 44078
df = DataFrame({"a": [(1,), (1,), (1,)], "b": [4, 5, 6]})
gb = df.groupby(["a"])
result = gb.rolling(2).corr(other=df)
index = MultiIndex.from_tuples([((1,), 0), ((1,), 1), ((1,), 2)], names=["a", None])
expected = DataFrame(
{"a": [np.nan, np.nan, np.nan], "b": [np.nan, 1.0, 1.0]}, index=index
)
tm.assert_frame_equal(result, expected)


def test_rolling_corr_case_grrouping_column_contains_tuples_2(df):
# GH 44078
df = DataFrame({"a": [(1, 2), (1, 2), (1, 2)], "b": [4, 5, 6]})
gb = df.groupby(["a"])
result = gb.rolling(2).corr(other=df)
index = MultiIndex.from_tuples(
[((1, 2), 0), ((1, 2), 1), ((1, 2), 2)], names=["a", None]
)
expected = DataFrame(
{"a": [np.nan, np.nan, np.nan], "b": [np.nan, 1.0, 1.0]}, index=index
)
tm.assert_frame_equal(result, expected)