Unit test for groupby.rolling.corr #54499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
omar-elbaz
commented
Aug 11, 2023
omar-elbaz
commented
- closes BUG: groupby.rolling.corr incorrect/fails when grouping columns contain tuples #44078
- Tests added and passed
- All code checks passed.
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
jreback
added
Testing
|
thanks @omar-elbaz |
mroeschke
reviewed
Aug 11, 2023
| @@ -3159,3 +3159,29 @@ def test_groupby_series_with_datetimeindex_month_name(): | |||
| expected = Series([2, 1], name="jan") | |||
| expected.index.name = "jan" | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_rolling_corr_grouping_column_contains_tuples_1(df): | |||
There was a problem hiding this comment.
Could you move these tests to pandas/tests/window/test_groupby.py in a follow up PR?
There was a problem hiding this comment.
Yeah sounds good, will get it in shortly
There was a problem hiding this comment.
Hey @mroeschke, this is the number for the new pr #54504, I'm just waiting for the checks to clear.
There was a problem hiding this comment.
@mroeschke the other PR went through please merge :) thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.