Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better cython debugging #53821

Merged
merged 3 commits into from
Oct 7, 2023
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jun 23, 2023

This is still super buggy but hopefully this gets people a bit closer

@WillAyd WillAyd requested a review from MarcoGorelli as a code owner June 23, 2023 18:57

python -m pip install -ve . --no-build-isolation --config-settings=builddir="debug" --config-settings=setup-args="-Dbuildtype=debug"

If planning to use cygdb, the files required by that application are placed within the build folder. So you have to first ``cd`` to the build folder, then start that application.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bug in Cython, which still uses optparse (deprecated in 3.2) insted of argparse. Seems like the tool should allow you to specify the build folder in theory, but in practice doesn't work. Will push up a PR separately to Cython to fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I haven't tried the docker image yet, but the changes suggested look good

@mroeschke mroeschke added the Docs label Jun 26, 2023
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jul 27, 2023
@MarcoGorelli
Copy link
Member

looks like some merge conflicts have crept in - if they're resolved, then can this be merged?

@datapythonista
Copy link
Member

@WillAyd is this something we want to move forward with? Can you fix the conflicts if it is please.

@WillAyd WillAyd requested a review from noatamir as a code owner October 7, 2023 12:52
@WillAyd
Copy link
Member Author

WillAyd commented Oct 7, 2023

Sorry forgot about this one. Yea I think its only helpful so happy to move forward with it

@datapythonista datapythonista merged commit fe5f0c9 into pandas-dev:main Oct 7, 2023
@datapythonista
Copy link
Member

Thanks for this @WillAyd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants