Fix/mpl37 compat #52150
Merged
Fix/mpl37 compat #52150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of mpl 3.7 all Axes now report as being instances of Subplots, however ax.get_subplotspec() may now return None if the Axes is not actually in gridspec.
The MPLPlot instance already holds a reference to the Figure, use that instead of walking up from the first Axes.
I was going to do it today. You were too fast :-) Thanks @tacaswell! |
|
Thanks @tacaswell BTW, we have a branch trying to support Matplotlib 3.7 but we don't really have experienced matplotlib contributors anymore. Any insights would be appreciated: #51990 |
3 tasks
|
@meeseeksdev backport 2.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 25, 2023
lithomas1
pushed a commit
that referenced
this pull request
Jun 26, 2023
Backport PR #52150: Fix/mpl37 compat Co-authored-by: Thomas A Caswell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported via matplotlib/matplotlib#25538 , I can not find an issue if @ocefpaf reported one.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.