Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Unpin matplotlib #51990

Merged
merged 5 commits into from
Apr 23, 2023
Merged

CI: Unpin matplotlib #51990

merged 5 commits into from
Apr 23, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 15, 2023

lets see if the new release addresses the failures

@phofl phofl added Visualization plotting CI Continuous Integration labels Mar 15, 2023
@phofl
Copy link
Member Author

phofl commented Mar 15, 2023

cc @mroeschke I think you took a closer look at the failures when 3.7 came out. Is this test failure expected and we have to fix it or is it on the matplotlib side?

@mroeschke
Copy link
Member

I don't remember seeing UserWarning: All values for SymLogScale are below linthresh, making it effectively linear. You likely should lower the value of linthresh. in the previous release. I suppose we can catch this in our test.

For AttributeError: 'NoneType' object has no attribute 'rowspan' I think we have to address this on our side. I tried addressing it with this (undo) commit but it caused other test failures I didn't really understand :/
a36f007

@mroeschke mroeschke mentioned this pull request Mar 24, 2023
3 tasks
@tacaswell
Copy link
Contributor

#52150 fixes one of the errors.

The other failure I think you should fix by making the data range bigger with your test data or add a warning filter to that test.

mroeschke and others added 4 commits April 7, 2023 10:52
# Conflicts:
#	ci/deps/actions-310.yaml
#	ci/deps/actions-311.yaml
#	ci/deps/actions-38-downstream_compat.yaml
#	ci/deps/actions-38.yaml
#	ci/deps/actions-39.yaml
#	ci/deps/circle-38-arm64.yaml
#	environment.yml
#	requirements-dev.txt
@phofl phofl added this to the 2.0.1 milestone Apr 23, 2023
@phofl phofl merged commit 2c68dd3 into pandas-dev:main Apr 23, 2023
@phofl phofl deleted the 51394 branch April 23, 2023 10:02
@lumberbot-app
Copy link

lumberbot-app bot commented Apr 23, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2c68dd3d9c415f40b04c500936670470c4eabd6e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #51990: CI: Unpin matplotlib'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-51990-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #51990 on branch 2.0.x (CI: Unpin matplotlib)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl added a commit to phofl/pandas that referenced this pull request Apr 23, 2023
@phofl phofl modified the milestones: 2.0.1, 2.1 Apr 23, 2023
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: matplotlib 3.7.0 broke ci
3 participants