COMPAT: Update code for latest Cython 3 beta #51640
Conversation
lithomas1
added
the
Compat
|
OK, this is ready, but needs a Cython bump to get the cpow directive added in 0.29.33 (best done separately). EDIT: All done. |
|
Going to put this in for now to get rid of red CI. If there's any further comments, I can take care of it in a followup. |
…thon 3 beta) (#51728) Backport PR #51640: COMPAT: Update code for latest Cython 3 beta Co-authored-by: Thomas Li <[email protected]>
| @@ -77,6 +75,9 @@ jobs: | |||
| env_file: actions-310-numpydev.yaml | |||
| pattern: "not slow and not network and not single_cpu" | |||
| test_args: "-W error::DeprecationWarning -W error::FutureWarning" | |||
| # TODO(cython3): Re-enable once next-beta(after beta 1) comes out | |||
| # There are some warnings failing the build with -werror | |||
| pandas_ci: 0 | |||
There was a problem hiding this comment.
Is there a commit available to install after beta 1 where the warnings are fixed? Setting this to 0 will affect some tests that are using is_ci_environment()
There was a problem hiding this comment.
I'll need to file a bug with Cython. If I did this correctly, only the numpy dev build should be affected.
There was a problem hiding this comment.
Okay yeah should be okay since it's only affecting one build, but good to have the tests as consistent as possible if cython can be bumped on this build
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.