Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: MyPy fixup #36085

Merged
merged 1 commit into from
Sep 3, 2020
Merged

CI: MyPy fixup #36085

merged 1 commit into from
Sep 3, 2020

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Sep 3, 2020 •
edited
Loading

https://github.com/pandas-dev/pandas/runs/1064831108

mypy --version
mypy 0.782
Performing static analysis using mypy
pandas/io/common.py:168: error: unused 'type: ignore' comment
pandas/io/common.py:170: error: Incompatible default for argument "encoding" (default has type "None", argument has type "str")  [assignment]
pandas/io/common.py:172: error: Incompatible default for argument "mode" (default has type "None", argument has type "str")  [assignment]
Found 3 errors in 1 file (checked 1037 source files)

@simonjayhawkins simonjayhawkins added the CI Continuous Integration label Sep 3, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Sep 3, 2020
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 3, 2020
Merged
12 tasks
@AlexKirko AlexKirko mentioned this pull request Sep 3, 2020
Merged
5 tasks
@charlesdong1991 charlesdong1991 mentioned this pull request Sep 3, 2020
Merged
3 tasks
charlesdong1991
charlesdong1991 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @simonjayhawkins

merged since several PRs are affected

@charlesdong1991 charlesdong1991 merged commit 309018c into pandas-dev:master Sep 3, 2020
@simonjayhawkins simonjayhawkins deleted the mypy-fixup branch September 3, 2020 10:22
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@simonjayhawkins
CI: MyPy fixup (pandas-dev#36085)
8b4e1c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesdong1991 charlesdong1991 charlesdong1991 approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @charlesdong1991