-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: resolve UserWarning in pandas/plotting/_matplotlib/core.py
#35945
#35946
CLN: resolve UserWarning in pandas/plotting/_matplotlib/core.py
#35945
#35946
Conversation
pandas/plotting/_matplotlib/core.py
#35945
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, @VirosaLi
just curious where is this warning getting caught or is the warning raised on a newer matplotlib version, do we have any tests right now to catch the warning?
pandas/tests/plotting/test_frame.py: 10 warnings |
@VirosaLi so the warning is now gone? I don't think we actually need a test for this, but if you can put an assert_produces_warning(None) around something and have it pass would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
if you could get the CI green (failure doesn't seem relevant to the PR though, maybe try to rebase one more time)
the first one will be resolved once #36085 gets merged. |
thanks @VirosaLi |
@meeseeksdev backport 1.1.x |
Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out. |
pandas/plotting/_matplotlib/core.py
#35945black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff