Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: resolve UserWarning in pandas/plotting/_matplotlib/core.py #35945 #35946

Merged
merged 5 commits into from
Sep 5, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Aug 28, 2020

@fangchenli fangchenli changed the title CLN: resolve UserWarning #35945 CLN: resolve UserWarning in pandas/plotting/_matplotlib/core.py #35945 Aug 28, 2020
@MarcoGorelli MarcoGorelli added the Visualization plotting label Aug 28, 2020
Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, @VirosaLi

just curious where is this warning getting caught or is the warning raised on a newer matplotlib version, do we have any tests right now to catch the warning?

pandas/plotting/_matplotlib/core.py Outdated Show resolved Hide resolved
@fangchenli
Copy link
Member Author

thanks for the PR, @VirosaLi

just curious where is this warning getting caught or is the warning raised on a newer matplotlib version, do we have any tests right now to catch the warning?

pandas/tests/plotting/test_frame.py: 10 warnings
pandas/tests/plotting/test_series.py: 5 warnings
/home/fangchenli/Workspace/pandas-VirosaLi/pandas/plotting/_matplotlib/core.py:1235: UserWarning: FixedFormatter should only be used together with FixedLocator
ax.set_xticklabels(xticklabels)

@jreback jreback added this to the 1.2 milestone Sep 3, 2020
@jreback
Copy link
Contributor

jreback commented Sep 3, 2020

@VirosaLi so the warning is now gone? I don't think we actually need a test for this, but if you can put an assert_produces_warning(None) around something and have it pass would be great.

Copy link
Member

@charlesdong1991 charlesdong1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if you could get the CI green (failure doesn't seem relevant to the PR though, maybe try to rebase one more time)

@charlesdong1991
Copy link
Member

the first one will be resolved once #36085 gets merged.

@jreback jreback merged commit c43652e into pandas-dev:master Sep 5, 2020
@jreback
Copy link
Contributor

jreback commented Sep 5, 2020

thanks @VirosaLi

@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 2, 2020

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@simonjayhawkins simonjayhawkins modified the milestones: 1.2, 1.1.2 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN: UserWarning in pandas/plotting/_matplotlib/core.py
5 participants