Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN remove unnecessary trailing commas in groupby tests #36059

Merged
merged 1 commit into from
Sep 2, 2020
Merged

CLN remove unnecessary trailing commas in groupby tests #36059

merged 1 commit into from
Sep 2, 2020

Conversation

xcz011
Copy link
Contributor

@xcz011 xcz011 commented Sep 2, 2020

xref #35925

@xcz011 xcz011 force-pushed the style_commas_remove branch from 9544213 to c15b559 Compare September 2, 2020 02:21
@pep8speaks
Copy link

pep8speaks commented Sep 2, 2020 •
edited
Loading

Hello @xcz011! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-02 12:13:40 UTC

@xcz011 xcz011 force-pushed the style_commas_remove branch 2 times, most recently from e88ae97 to ee696ea Compare September 2, 2020 02:37
MarcoGorelli
MarcoGorelli reviewed Sep 2, 2020
View reviewed changes
pandas/tests/groupby/test_timegrouper.py Outdated
@@ -408,7 +408,7 @@ def test_timegrouper_apply_return_type_series(self):
df_dt["date"] = pd.to_datetime(df_dt["date"])

def sumfunc_series(x):
return pd.Series([x["value"].sum()], ("sum",))
return pd.Series([x["value"].sum()], ("sum"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one shouldn't change, as ('sum', ) is a tuple. The rest looks good though 👍

@xcz011 xcz011 force-pushed the style_commas_remove branch from ee696ea to 2a0cb4e Compare September 2, 2020 12:13
MarcoGorelli
MarcoGorelli approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @xcz011 !

@MarcoGorelli MarcoGorelli added this to the 1.2 milestone Sep 2, 2020
@simonjayhawkins simonjayhawkins merged commit a0d92b6 into pandas-dev:master Sep 2, 2020
@simonjayhawkins
Copy link
Member

Thanks @xcz011

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@xcz011
CLN remove unnecessary trailing commas in groupby tests (pandas-dev#3…
75b2dcd 
…6059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@xcz011 @pep8speaks @simonjayhawkins @MarcoGorelli