Fix type annotations in pandas.core.computation #26295
Conversation
pandas/core/computation/ops.py
Outdated
| @@ -166,7 +166,8 @@ def __init__(self, value, env, side=None, encoding=None): | |||
| def _resolve_name(self): | |||
| return self._name | |||
|
|
|||
| @property | |||
| # read-only property overwriting read/write | |||
| @property # type: ignore | |||
There was a problem hiding this comment.
Handling these as here
Codecov Report
@@ Coverage Diff @@
## master #26295 +/- ##
==========================================
- Coverage 92.04% 92.04% -0.01%
==========================================
Files 175 175
Lines 52302 52301 -1
==========================================
- Hits 48142 48138 -4
- Misses 4160 4163 +3
Continue to review full report at Codecov.
|
|
can you merge master; @WillAyd |
pandas/core/computation/ops.py
Outdated
| @@ -166,7 +166,8 @@ def __init__(self, value, env, side=None, encoding=None): | |||
| def _resolve_name(self): | |||
| return self._name | |||
|
|
|||
| @property | |||
| # read-only property overwriting read/write | |||
| @property # type: ignore | |||
There was a problem hiding this comment.
Could we just remove the setters from the base class or are they actually used?
There was a problem hiding this comment.
We can remove the name setter, but removing the the value setter flunks a whole mess of tests. Will push a commit with the former and its accompanying type comment removed. Merging master while I'm at it.
|
Thanks @gwrome ! Very nice progress on all of these typing PRs |
git diff upstream/master -u -- "*.py" | flake8 --diff