Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type annotations in pandas.core.computation #26294

Closed
gwrome opened this issue May 6, 2019 · 0 comments · Fixed by #26295
Closed

Fix type annotations in pandas.core.computation #26294

gwrome opened this issue May 6, 2019 · 0 comments · Fixed by #26295
Labels
Typing type annotations, mypy/pyright type checking
Milestone
0.25.0

Comments

@gwrome
Copy link
Contributor

gwrome commented May 6, 2019 •
edited
Loading

Part of #25882

The files in pandas.core.computation have the following errors:

pandas/core/computation/ops.py:169: error: Read-only property cannot override read-write property
pandas/core/computation/pytables.py:59: error: Read-only property cannot override read-write property
pandas/core/computation/pytables.py:384: error: Incompatible types in assignment (expression has type "Type[pandas.core.computation.pytables.Constant]", base class "BaseExprVisitor" defined the type as "Type[pandas.core.computation.ops.Constant]")

Pull request to follow.
@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label May 6, 2019
@gwrome gwrome mentioned this issue May 6, 2019
Merged
3 tasks
@jreback jreback added this to the 0.25.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Fix type annotations in pandas.core.computation gwrome/pandas
3 participants
@WillAyd @jreback @gwrome