Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Test for private modules exposed via API #25935

Merged
merged 1 commit into from
Apr 1, 2019
Merged

TST: Test for private modules exposed via API #25935

merged 1 commit into from
Apr 1, 2019

Conversation

ryankarlos
Copy link
Contributor

@ryankarlos ryankarlos changed the title TST: Add test for private modules exposed via API TST: Test for private modules exposed via API Mar 31, 2019
@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #25935 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25935      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52580    52580              
==========================================
- Hits        48278    48274       -4     
- Misses       4302     4306       +4
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3a85c...529ba8c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 31, 2019 •
edited
Loading

Codecov Report

Merging #25935 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25935      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         175      175              
  Lines       52580    52580              
==========================================
- Hits        48278    48274       -4     
- Misses       4302     4306       +4
Flag Coverage Δ
#multiple 90.36% <ø> (ø) ⬆️
#single 41.9% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 75% <0%> (-12.5%) ⬇️
pandas/core/frame.py 96.79% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3a85c...529ba8c. Read the comment docs.

@WillAyd WillAyd added the Testing pandas testing functions or related to the test suite label Mar 31, 2019
@WillAyd WillAyd added this to the 0.25.0 milestone Mar 31, 2019
WillAyd
WillAyd approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! @jreback

@jreback jreback merged commit 3989e47 into pandas-dev:master Apr 1, 2019
@jreback
Copy link
Contributor

jreback commented Apr 1, 2019

thanks @ryankarlos

@ryankarlos ryankarlos deleted the test_api_private_modules branch April 2, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Add Test to Explicitly Check Private Modules Exposed via API
3 participants
@ryankarlos @jreback @WillAyd